Skip to content

feat: add new dashboard layout #3407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Dec 16, 2024
Merged

feat: add new dashboard layout #3407

merged 16 commits into from
Dec 16, 2024

Conversation

andre-code
Copy link
Contributor

@andre-code andre-code commented Nov 22, 2024 •
edited
Loading

PR to add new dashboard layout

/deploy renku=andrea/update-dashboard-layout renku-data-services=main

@andre-code andre-code changed the title feat: add new dashboard layout [wip] feat: add new dashboard layout Nov 22, 2024
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3407.dev.renku.ch

@andre-code andre-code force-pushed the andrea/add-new-dashboard-layout branch from 8d80538 to 66c8efb Compare November 29, 2024 11:10
@andre-code andre-code force-pushed the andrea/add-new-dashboard-layout branch from 66c8efb to 8ba55fe Compare December 2, 2024 09:36
@andre-code andre-code changed the title [wip] feat: add new dashboard layout feat: add new dashboard layout Dec 3, 2024
@andre-code andre-code force-pushed the andrea/add-new-dashboard-layout branch from 006ce44 to 9c19dd5 Compare December 6, 2024 09:18
@leafty
Copy link
Member

leafty commented Dec 12, 2024

Thanks @leafty for your review, the reason for calculating the avatar based on the slug/username instead of the initials is to ensure consistency across the app.

Also, this is wrong, since the existing pages use the initials (which is much more appropriate) than the namespace slug.

@andre-code
Copy link
Contributor Author

Thanks @leafty for your review, the reason for calculating the avatar based on the slug/username instead of the initials is to ensure consistency across the app.

Also, this is wrong, since the existing pages use the initials (which is much more appropriate) than the namespace slug.

I understand the confusion. The changes required for the group and user pages are addressed in the other PRs. Here, you’ll see the avatar functioning consistently across all pages. https://renku-ci-ui-3433.dev.renku.ch/

@leafty
Copy link
Member

leafty commented Dec 12, 2024 •
edited
Loading

Thanks @leafty for your review, the reason for calculating the avatar based on the slug/username instead of the initials is to ensure consistency across the app.

Also, this is wrong, since the existing pages use the initials (which is much more appropriate) than the namespace slug.

I understand the confusion. The changes required for the group and user pages are addressed in the other PRs. Here, you’ll see the avatar functioning consistently across all pages. https://renku-ci-ui-3433.dev.renku.ch/

Well, it is irksome to not see initials in that PR, to be honest. The initial component was created to use initials because it is what users would expect this type of "Avatar with initials" to be. Anyway, I will have a PR ready to fix the avatars and use initials (not just the first two letters). -> #3437

leafty
leafty approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be OK to merge now. Good work.

leafty
leafty requested changes Dec 12, 2024
View reviewed changes
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, should be good to go once the footer cards are fixed.

leafty
leafty previously approved these changes Dec 13, 2024
View reviewed changes
client/src/features/dashboardV2/DashboardV2.tsx Outdated
className={cx(
DashboardStyles.DashboardCard,
"border-0",
"position-relative"
Copy link
Member

@leafty leafty Dec 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this changes anything.

Suggested change
"position-relative"

leafty
leafty reviewed Dec 13, 2024
View reviewed changes
client/src/features/dashboardV2/DashboardV2.module.scss Outdated
a svg {
transition: all 0.3s linear;
}
a:hover svg {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small detail, but this would be nice:

Suggested change
a:hover svg {
a:hover svg, a:focus svg {

Reference: https://webaim.org/techniques/hypertext/link_text#hover

leafty
leafty reviewed Dec 16, 2024
View reviewed changes
@andre-code andre-code merged commit 75046e4 into main Dec 16, 2024
20 checks passed
@andre-code andre-code deleted the andrea/add-new-dashboard-layout branch December 16, 2024 14:32
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

leafty pushed a commit that referenced this pull request Apr 22, 2025
@andre-code @leafty
feat: clean up the Renku 2.0 dashboard for Early Access (#3407)
c5fc3d0 
fix #3440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leafty leafty leafty approved these changes

Assignees

@leafty leafty

Labels
ShapeUp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andre-code @RenkuBot @leafty